Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to iterate and debug and fix tests and all that jazz
Not ready for review
Description
This PR introduces the concept of 'Group Creation Requests', sometimes referred to in the code as Group Requests. This will allow users to, as the name suggests, request that a group is created.
The user provides the desired group:
This request is then created so that Access admins (and app owners if the requested group is an app group) can approve/reject it. Users may also reject their own requests.
Additional changes have been added to the plugins and audit logging to support the new request type
Notes
A few other bug fixes and circular import fixes added in as well (eg. in modify_group_tags.py)
How to review
Unfortunately, this PR is massive and not easily broken up. Probably start with models and schemas in case any changes need to be made there (which will affect the rest of the code), then operations, then the rest
TODO after initial review
TODO in follow up PRs: