Limit provider error response to 1000 characters #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcodybaker
approved these changes
Feb 27, 2025
fgrutsch
added a commit
to lovelysystems/flipop
that referenced
this pull request
Jul 17, 2025
* Upgrade Golang to 1.22 and all dependencies to their latest state * add modern leases to RBAC * dns only for assigned ips * fix test * update dns on all ip allocation changes (digitalocean#35) * Upgrade go version in Makefile (digitalocean#32) * Fix typo in comments (digitalocean#31) * bump dependencies (digitalocean#36) * fix examples to use common namespace + recent versions (digitalocean#37) * Limit provider error response to 1000 characters (digitalocean#38) * APPS-10526 Upgrade go deps (digitalocean#40) * Use docker's recommend key value format * Upgrade deps * Generate k8s * add annotation when IP assigned or change in assignments * only ignore updates if both match status and reserved IP are not changed * ndoedns controller supports flipop.digitalocean.com/ipv4-reserved-ip addressType * README update * annotationUpdater now uses NodeInformer cache to validate current annotation value * don't use latest tag for docker image --------- Co-authored-by: Markus Thömmes <mthoemmes@digitalocean.com> Co-authored-by: Cody Baker <cbaker@digitalocean.com> Co-authored-by: Aryan Ahmed <thearyanahmed@gmail.com> Co-authored-by: kibeom lee <46297213+lkb85@users.noreply.github.com> Co-authored-by: Aryan Ahmed <paryan@digitalocean.com> Co-authored-by: Joe Keegan <jkeegan@digitalocean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits error response that is sent to kubernetes, to the first 1000 characters.
Context:
App platform received resource exhausted alert on flipop :
ResourceExhausted error (desc = trying to send message larger than max (2361634 vs. 2097152)) in the flipop pod (5 restarts in 30h).flipop updates the status message in the floatingippool resource when it encounters an error. That message includes the response it got back from the API. When Cloud Control Panel / API is down (see inci-1955), we display a big html file containing an image.
Which made the response size > 2MB , which is gRPC's default.
https://logs.internal.digitalocean.com/goto/f4a59480-f483-11ef-9702-c10ab0923a22