Collect Reply Tweets#13
Open
greenwoodma wants to merge 3 commits intodigitalmethodsinitiative:masterfrom
Open
Conversation
Author
|
I've now updated this branch to also add flags for both promoted and related tweets. This uses the same approach as #17 for the promoted tweets (i.e. if you merge this PR that one is probably redundant) but extends it also to the reply tweets. A similar flag is then also used for the related tweets (these are the ones usually under a "Discover More" heading when viewed on the twitter web site). I know multiple items in a single PR isn't the best strategy, but given the refactoring in the original it made more sense to add these extra flags here than in another PR that would have required extensive re-working if they were merged separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relates to issue #10
Essentially with the current version of the plugin, if you view the page for a single tweet then nothing is collected (not the tweet being viewed or any of the replies). This PR fixes that by collecting data from the
TweetDetailendpoint. The code for checking a normal tweet object has been pulled out into a function so we can use it under multiple conditions (relating to the different API endpoints and their structures) which avoids code duplication but does make more changes to the code than I originally intended.