Skip to content

Conversation

@DamienGilliard
Copy link
Collaborator

@DamienGilliard DamienGilliard commented Jan 16, 2026

This PR contains changes that improve the CAD segmentation in "difficult" CAD-pc cases

It includes;

  • a homogenization of normals that appear to be easily flipped on horizontal surfaces: now all normals are facing up
  • a fallback solution for beams that have only 2 parallel faces in the scan: we use bounding boxes to find secondary axis
image

@DamienGilliard DamienGilliard self-assigned this Jan 16, 2026
@DamienGilliard DamienGilliard marked this pull request as draft January 16, 2026 18:50
@DamienGilliard DamienGilliard added enhancement New feature or request dev backend labels Jan 16, 2026
@DamienGilliard DamienGilliard linked an issue Jan 16, 2026 that may be closed by this pull request
@DamienGilliard
Copy link
Collaborator Author

DamienGilliard commented Jan 28, 2026

Hi @eleniv3d , This PR seems ready for review !
Here is a file to test it;

2026_01_28_test_df2.zip

@eleniv3d
Copy link
Collaborator

Hi @eleniv3d , This PR seems ready for review ! Here is a file to test it;

2026_01_28_test_df2.zip

unfortunatelly the pcd input is internalized in a cockroach cloud parameter which i have tried before to install but doesnt work :/ would it be possible to put i in a gh pcd parameter? :)

pcd_input

@DamienGilliard
Copy link
Collaborator Author

damn.
Here it is:
2026_01_28_test_df2_with_gh_pointcloud.zip

@eleniv3d
Copy link
Collaborator

i remember last time we also discussed the option to introduce another filter in the loop that associates each beam that looks more or less like this:

#build a BRep-sampled point cloud for each beam
#run ICP with source = brep_cloud, target = associated beam cloud
#use the resulting transform to compute a registered bounding box of the brep
#“unassociate” any face-assigned points outside that bbox

i just leave it here as a thought..

@eleniv3d eleniv3d marked this pull request as ready for review January 29, 2026 15:50
@eleniv3d eleniv3d merged commit 84a5d21 into release/2.0.0 Jan 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend dev enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

normal segmentation gives wierd segments

3 participants