Skip to content

Fix: avoid writer issues with ranges returning __int128 from Ranges::size #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dglaeser wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: avoid writer issues with ranges returning __int128 from Ranges::size #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions gridformat/common/ranges.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ namespace GridFormat::Ranges {
*/
template<std::ranges::sized_range R>
requires(!Concepts::StaticallySizedRange<R>)
inline constexpr auto size(R&& r) {
return std::ranges::size(r);
inline constexpr std::size_t size(R&& r) {
return static_cast<std::size_t>(std::ranges::size(r));
}

/*!
Expand All @@ -44,17 +44,17 @@ inline constexpr auto size(R&& r) {
template<std::ranges::range R>
requires(!std::ranges::sized_range<R> and
!Concepts::StaticallySizedRange<R>)
inline constexpr auto size(R&& r) {
return std::ranges::distance(r);
inline constexpr std::size_t size(R&& r) {
return static_cast<std::size_t>(std::ranges::distance(r));
}

/*!
* \ingroup Common
* \brief Return the size of a range with size known at compile time.
*/
template<Concepts::StaticallySizedRange R>
inline constexpr auto size(R&&) {
return static_size<R>;
inline constexpr std::size_t size(R&&) {
return static_cast<std::size_t>(static_size<R>);
}

/*!
Expand Down