Global task hooks - remove case references#3
Draft
tobraha wants to merge 4 commits intodfir-iris:masterfrom
Draft
Global task hooks - remove case references#3tobraha wants to merge 4 commits intodfir-iris:masterfrom
tobraha wants to merge 4 commits intodfir-iris:masterfrom
Conversation
Author
|
Moved this PR to Draft as I'm adding in another minor fix for the report webhooks as well. The I'm adding in something like this, but I'm still testing things out. diff --git a/iris_webhooks_module/IrisWebHooksInterface.py b/iris_webhooks_module/IrisWebHooksInterface.py
index bf32c46..388b393 100644
--- a/iris_webhooks_module/IrisWebHooksInterface.py
+++ b/iris_webhooks_module/IrisWebHooksInterface.py
@@ -275,7 +275,9 @@ class IrisWebHooksInterface(IrisModuleInterface):
object_url = f"{server_url}/dashboard?cid=1#gtasks_table_wrapper"
elif hook_object == 'report':
+ user_name = data[0].user_update.name
object_name = 'a report'
+ case_name = data[0].case.name
if object_url:
object_name = self._render_url(object_url, object_name, request_rendering) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull creates a new elif for global_task hooks and normalizes the data referring to a specific case as it does not exist for a global task.
I'm using the following configuration for the webhook to post to Microsoft Teams:
{ "instance_url": "https://iris.dev", "webhooks": [ { "name": "Microsoft Teams", "active": true, "trigger_on": [ "on_postload_case_create", "on_postload_case_delete", "on_postload_ioc_create", "on_postload_ioc_update", "on_postload_evidence_create", "on_postload_evidence_update", "on_postload_task_create", "on_postload_task_update", "on_postload_global_task_create", "on_postload_global_task_update", "on_postload_report_create", "on_postload_activities_report_create" ], "request_url": "https://my.webhook.url/stuff", "request_rendering": "html", "request_body": { "title" : "%TITLE%", "text" : "%DESCRIPTION%" } } ] }Bump module version to 1.0.3
Resolves #2