Skip to content

test: Refactor IC-OS image config in system_tests.bzl for more clarity #8436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frankdavid wants to merge 4 commits into
base: master
Choose a base branch
from
+140 −150
Open

test: Refactor IC-OS image config in system_tests.bzl for more clarity #8436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4943f6e
test: Refactor IC-OS image config in system_tests.bzl for more clarity
frankdavid Jan 19, 2026
78bf869
Merge remote-tracking branch 'origin/master' into frankdavid/system-t…
frankdavid Jan 20, 2026
262930c
Automatically fixing code for linting and formatting issues
Jan 20, 2026
22047d4
comments and nits
frankdavid Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions rs/tests/nested/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ system_test_nns(
name = "registration",
env = MAINNET_ENV,
flaky = True, # flakiness rate of over 2% over the month from 2025-02-11 till 2025-03-11.
setupos = True,
tags = ["long_test"], # since it takes longer than 5 minutes.
test_timeout = "eternal",
uses_setupos_img = True,
runtime_deps = IC_GATEWAY_RUNTIME_DEPS,
deps = [
# Keep sorted.
Expand Down Expand Up @@ -81,10 +81,10 @@ system_test_nns(
env = MAINNET_ENV,
flaky = True,
guestos_update = "test",
setupos = True,
tags = ["long_test"],
test_driver_target = ":guestos_upgrade_test_bin",
test_timeout = "eternal",
uses_setupos_img = True,
runtime_deps = IC_GATEWAY_RUNTIME_DEPS,
)

Expand All @@ -94,10 +94,10 @@ system_test_nns(
flaky = True,
guestos = "mainnet_latest_dev", # necessary for configuring NNS public key
guestos_update = True,
setupos = "mainnet_latest",
tags = ["long_test"],
test_driver_target = ":guestos_upgrade_test_bin",
test_timeout = "eternal",
uses_setupos_mainnet_latest_img = True,
runtime_deps = IC_GATEWAY_RUNTIME_DEPS | {
"NODE_OPERATOR_PRIV_KEY_PATH": "//ic-os/setupos:config/node_operator_private_key.pem",
},
Expand All @@ -122,11 +122,11 @@ system_test_nns(
name = "hostos_upgrade_smoke_test",
env = MAINNET_ENV,
flaky = True,
hostos_update = "test",
setupos = True,
tags = ["long_test"],
test_driver_target = ":hostos_upgrade_test_bin",
test_timeout = "eternal",
uses_hostos_test_update = True,
uses_setupos_img = True,
runtime_deps = IC_GATEWAY_RUNTIME_DEPS,
)

Expand All @@ -135,11 +135,11 @@ system_test_nns(
name = "hostos_upgrade_from_latest_release_to_current",
flaky = True, # flakiness rate of 5% over the month from 2025-02-11 till 2025-03-11.
guestos = "mainnet_latest_dev", # necessary for configuring NNS public key
hostos_update = True,
setupos = "mainnet_latest",
tags = ["long_test"],
test_driver_target = ":hostos_upgrade_test_bin",
test_timeout = "eternal",
uses_hostos_update = True,
uses_setupos_mainnet_latest_img = True,
runtime_deps = IC_GATEWAY_RUNTIME_DEPS | {
"NODE_OPERATOR_PRIV_KEY_PATH": "//ic-os/setupos:config/node_operator_private_key.pem",
},
Expand Down
10 changes: 5 additions & 5 deletions rs/tests/nested/nns_recovery/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ system_test_nns(
env = ENV,
flaky = True,
guestos_update = "test",
setupos = True,
tags = ["long_test"],
test_timeout = "eternal",
uses_setupos_img = True,
runtime_deps = RUNTIME_DEPS,
deps = [
# Keep sorted.
Expand All @@ -66,12 +66,12 @@ system_test_nns(
env = ENV,
flaky = True,
guestos_update = "test",
setupos = True,
tags = [
"manual",
"system_test_large",
],
test_timeout = "eternal",
uses_setupos_img = True,
runtime_deps = RUNTIME_DEPS,
deps = [
# Keep sorted.
Expand All @@ -86,9 +86,9 @@ system_test_nns(
env = ENV,
flaky = True,
guestos_update = "test",
setupos = True,
tags = ["long_test"],
test_timeout = "eternal",
uses_setupos_img = True,
runtime_deps = RUNTIME_DEPS,
deps = [
# Keep sorted.
Expand All @@ -106,9 +106,9 @@ system_test_nns(
env = ENV,
flaky = True,
guestos_update = "test",
setupos = True,
tags = ["long_test"],
test_timeout = "eternal",
uses_setupos_img = True,
runtime_deps = RUNTIME_DEPS,
deps = [
# Keep sorted.
Expand All @@ -126,9 +126,9 @@ system_test_nns(
env = ENV,
flaky = True,
guestos_update = "test",
setupos = True,
tags = ["long_test"],
test_timeout = "eternal",
uses_setupos_img = True,
runtime_deps = RUNTIME_DEPS,
deps = [
# Keep sorted.
Expand Down
2 changes: 1 addition & 1 deletion rs/tests/node/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,11 @@ system_test(
system_test(
name = "launch_single_host",
guestos = False,
setupos = True,
tags = [
"dynamic_testnet",
"manual",
],
uses_setupos_img = True,
deps = [
# Keep sorted.
"//rs/tests/driver:ic-system-test-driver",
Expand Down
Loading
Loading