fix(ckdoge): reject deposits below minimum amount #8428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorydemay
added
the
CI_OVERRIDE_DIDC_CHECK
gregorydemay
changed the title
THLO
reviewed
Jan 21, 2026
|
|
||
| for utxo in processable_utxos { | ||
| if utxo.value <= check_fee { | ||
| let ignored_reason = if utxo.value < deposit_btc_min_amount { |
Contributor
There was a problem hiding this comment.
Nit: One would expect that a deposit of exactly deposit_btc_min_amount is permissible because the name suggests that it is the minimum accepted value.
THLO
reviewed
Jan 21, 2026
| ecdsa_key_name : text; | ||
|
|
||
| // The minimal amount of BTC that can be converted to ckBTC. | ||
| deposit_btc_min_amount : opt nat64; |
Contributor
There was a problem hiding this comment.
What is the advantage of having a concrete parameter?
Why not simply have effective_deposit_min_btc_amount return max(MINTER_ADDRESS_P2WPKH_DUST_LIMIT, check_fee+1)?
THLO
reviewed
Jan 21, 2026
| ecdsa_key_name : text; | ||
|
|
||
| // The minimal amount of DOGE that can be converted to ckDOGE. | ||
| deposit_doge_min_amount : opt nat64; |
Contributor
There was a problem hiding this comment.
The same question here: Is there a good reason to have this as a parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that DOGE deposits will be ignored when their value is below a configurable minimum amount. This is needed to ensure that the minter does not control UTXOs whose value are below the dust threshold (0.01 DOGE). This was not a problem for ckBTC, which deducts a
check_feeon the deposited UTXO value and whose value is above the Bitcoin dust threshold. In contrast, ckDOGE does not deduct a checker fee (check_feeis0), but still requires deposited UTXOs to have sufficient value.For that reason, the following changes were made to the ckBTC and ckDOGE minter:
deposit_btc_min_amount, which controls the minimum value a deposited UTXO must have to avoid being ignored.check_feeanddeposit_btc_min_amount) is returned as part of theMinterInfoand displayed on the minter dashboard.About
CI_OVERRIDE_DIDC_CHECK: the following non-breaking changes were made to the Candid interface:ckbtc_minter.didInitArgsandUpgradeArgsMinterInfockdoge_minter.did: the ckDOGE minter is not yet live, so that any change here is by definition not breaking.