feat: add persistent term to state retrieving benchmark#23
Open
polvalente wants to merge 2 commits intodevonestes:masterfrom
Open
feat: add persistent term to state retrieving benchmark#23polvalente wants to merge 2 commits intodevonestes:masterfrom
polvalente wants to merge 2 commits intodevonestes:masterfrom
Conversation
Owner
|
Good idea! There's just a merge conflict, but after that's fixed I think this is a good addition. |
Contributor
Author
@devonestes conflicts resolved! I guess most of them were due to some auto-formatter in my editor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there was a benchmark about state retrieval which did not include
persistent_terms. I added them to the benchmark. However, there is no benchmark for writing speed or for read-write roundtrip speed. Maybe we should add them in a next pull request?