Fix GOWS chats/overview missing contact name and WEBJS presence with @lid#1940
Open
niels-przybilla wants to merge 1 commit intodevlikeapro:corefrom
Open
Conversation
…e with @lid GOWS: Add contact name fallback in fetchChatSummary() - when chat.name is null, look up contact via GetContactById to resolve Name/PushName. Fixes devlikeapro#1910. WEBJS: Convert @lid to @c.us in getPresence() and subscribePresence() using findPNByLid() before passing to underlying client, since getCurrentPresence() only handles @c.us format correctly. Fixes devlikeapro#1845. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/{session}/chats/overviewendpoint. Whenchat.nameis null (common with GOWS gRPC responses), the code now falls back to looking up the contact viaGetContactByIdand usesNameorPushName. Follows the same pattern as the NOWEB engine.@lidchat IDs.getPresence()andsubscribePresence()now convert@lidto@c.usformat usingfindPNByLid()before passing to the underlying client, sincegetCurrentPresence()only handles@c.usformat correctly.Fixes #1910
Fixes #1845
Test plan
GET /api/{session}/chats/overviewand verify contact names are populated (not null)GET /api/{session}/presence/{lid_chat_id}with an@lidformat ID and verify presence data is returnedGET /api/{session}/presence/{c_us_chat_id}with an@c.usformat ID and verify it still works as before🤖 Generated with Claude Code