docs: Rewrite README with architecture diagram and examples#19
docs: Rewrite README with architecture diagram and examples#19facundofarias merged 4 commits intomasterfrom
Conversation
…shooting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughThe README.md file has been completely rebranded from "Deploy Agent Client" to "Deploy Agent" with a restructured documentation layout. Changes include a new "How It Works" architectural diagram, reorganized Quick Start instructions, expanded Commands and Configuration sections with detailed ~/.deploy/ file documentation, reworked Troubleshooting guidance, and updated Development/Release sections incorporating Conventional Commits standards. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 7-12: The fenced code block containing the ASCII diagram lacks a
language identifier (triggering MD040); update the triple-backtick fence around
the diagram (the block that starts with ``` and contains the ASCII diagram lines
with "DeployHQ", "Deploy Agent", and "Your Server(s)") to include a language
token such as text (i.e., change ``` to ```text) so markdownlint passes.
- Around line 98-106: The fenced code block in README.md lacks a language
identifier (MD040); update the opening triple backticks for the access list
example to include a language such as `text` or `conf` (i.e., change ``` to
```text or ```conf) so the block is properly annotated and Markdownlint stops
flagging MD040.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b2b85035e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
README.md
Outdated
| ## Requirements | ||
|
|
||
| - Ruby 2.7 or later | ||
| - Outbound access to DeployHQ on port 7777 |
There was a problem hiding this comment.
Add HTTPS setup endpoint to firewall requirements
The requirements list implies that opening outbound port 7777 is sufficient, but initial setup also needs outbound HTTPS to api.deployhq.com:443 to request the client certificate (ConfigurationGenerator#certificate_uri in lib/deploy_agent/configuration_generator.rb). In environments that follow this README literally and only allow 7777, deploy-agent setup will fail before the agent can be provisioned.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The setup wizard needs outbound HTTPS to api.deployhq.com to request the client certificate, not just port 7777. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
🤖 Generated with Claude Code
Summary by CodeRabbit