fix: Update dependencies to support GCC 14 / Debian 13#16
Merged
facundofarias merged 2 commits intomasterfrom Feb 19, 2026
Merged
fix: Update dependencies to support GCC 14 / Debian 13#16facundofarias merged 2 commits intomasterfrom
facundofarias merged 2 commits intomasterfrom
Conversation
nio4r 2.1.0 fails to compile with GCC 14 (shipped in Debian 13) because -Wincompatible-pointer-types is now treated as an error. Relax dependency pins to allow nio4r ~> 2.7, timers ~> 4.3, and rb-readline ~> 0.5. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughUpdated gem dependency version constraints in deploy-agent.gemspec, replacing exact version pins with pessimistic version ranges for nio4r ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/deploy_agent/agent.rb`:
- Around line 1-2: Remove the explicit gem activation calls for 'nio4r' and
'timers' from the library file (the lines calling gem 'nio4r', '~> 2.7' and gem
'timers', '~> 4.3') so that dependency resolution is left to the gemspec
(s.add_dependency) and Bundler; simply delete those two gem lines from agent.rb
to avoid runtime gem activation on require and potential version conflicts.
Dependency resolution is already handled by the gemspec's add_dependency declarations. Explicit gem activation calls can cause version conflicts when multiple versions are installed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thdurante
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nio4r2.1.0 →~> 2.7,timers4.1.2 →~> 4.3,rb-readline0.5.5 →~> 0.5) to fix compilation failures on Debian 13 / GCC 14nio4r 2.1.0uses a function pointer type (VALUE (*)(void *)) where GCC 14 now requiresvoid * (*)(void *), promoting-Wincompatible-pointer-typesfrom warning to errortimers 4.3also drops thehitimesnative extension dependency, reducing further compilation riskContext
A customer on Debian 13 (Ruby 3.3, GCC 14) cannot install the agent at all —
gem install deploy-agentfails during native extension compilation.Test plan
🤖 Generated with Claude Code