Support for function args + local variables#322
Draft
mmaybee wants to merge 2 commits intodelphix:developfrom
Draft
Support for function args + local variables#322mmaybee wants to merge 2 commits intodelphix:developfrom
mmaybee wants to merge 2 commits intodelphix:developfrom
Conversation
ahrens
reviewed
Mar 21, 2023
sdb/commands/linux/stacks.py
Outdated
| ... | ||
| """ | ||
|
|
||
| names = ["stack_args"] |
Contributor
There was a problem hiding this comment.
other names we might consider for this:
locals(it prints local variables)stack --args(extension to existing command rather than new command)
ca4746e to
482a982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
= Problem
Need a convenient way to see argument names and associated values when viewing call stacks.
= Solution
This PR introduces a new command
stack_argsthat can be used to display detailed information (including values for local variables) for frames in a call stack. It takes one or more stack pointers as input. E.g.The command accepts two arguments:
-f <frame#>- will print only the requested frame of the stack, and provide more detail values provided for locals.-r- will print available register values for each stack frame.Note that the syntax used here is still evolving and subject to change.