CP-13163 Update performance-diagnostic to install docker from official docker repo#114
Open
SumoSourabh wants to merge 1 commit intodevelopfrom
Open
Conversation
SumoSourabh
force-pushed
the
dlpx/pr/SumoSourabh/5328f2fc-efd0-48d6-a0ba-3263c6b5150d
branch
from
fe8b990 to
8f558de
Compare
SumoSourabh
force-pushed
the
dlpx/pr/SumoSourabh/5328f2fc-efd0-48d6-a0ba-3263c6b5150d
branch
from
8f558de to
e845b71
Compare
SumoSourabh
changed the title
SumoSourabh
changed the title
SumoSourabh
force-pushed
the
dlpx/pr/SumoSourabh/5328f2fc-efd0-48d6-a0ba-3263c6b5150d
branch
3 times, most recently
from
bbdab1f to
571cae7
Compare
SumoSourabh
force-pushed
the
dlpx/pr/SumoSourabh/5328f2fc-efd0-48d6-a0ba-3263c6b5150d
branch
from
571cae7 to
a822c5a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We are using docker.io package provided by Ubuntu which is quite old and is not in sync with the official docker release.
Solution
Update ubuntu docker.io package with docker-ce (official docker community addition) to keep the docker installation in sync with the latest release
As the change needs changes from dlpx-app-gate also, another PR https://github.com/delphix/dlpx-app-gate/pull/3929 with changes related to docker.io -> docker-ce is raised.
Both PRs will be merged together as dependents.
Testing Done
ab-pre-push with only this PR changes are failing as per the review checks.
ab-pre-push with both PR changes is triggered at - https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/13355/