Adding additional storage / backend adapter draft#2084
Open
johnmcswain wants to merge 2 commits intodeepforge-dev:masterfrom
Open
Adding additional storage / backend adapter draft#2084johnmcswain wants to merge 2 commits intodeepforge-dev:masterfrom
johnmcswain wants to merge 2 commits intodeepforge-dev:masterfrom
Conversation
brollb
requested changes
Apr 14, 2023
Contributor
brollb
left a comment
brollb
left a comment
There was a problem hiding this comment.
Hi @johnmcswain! Thanks for the PR. It looks like it is still a work in progress but I added some comments in case they are helpful!
Contributor
There was a problem hiding this comment.
Move this file (and Storage.js) to be in the udcp folder.
| @@ -0,0 +1,80 @@ | |||
| /* globals define */ | |||
| import {Storage} from "../Storage" | |||
Contributor
There was a problem hiding this comment.
Change this to use requirejs for importing. (This one is likely going to throw an error as I doubt import statements are supported in this version.)
| @@ -0,0 +1,26 @@ | |||
| /*global define*/ | |||
| define([ | |||
| 'deepforge/udcpConfig', | |||
Contributor
There was a problem hiding this comment.
I don't think this file exists, does it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brollb I've started the following steps: