fix the issue of cursor movement using arrow keys in the search bar for links#104
Open
flakeed wants to merge 2 commits intodeep-foundation:mainfrom
Open
fix the issue of cursor movement using arrow keys in the search bar for links#104flakeed wants to merge 2 commits intodeep-foundation:mainfrom
flakeed wants to merge 2 commits intodeep-foundation:mainfrom
Conversation
Member
|
Associated with https://github.com/deep-foundation/deepcase/issues/102 |
konard
requested changes
May 6, 2023
Comment on lines
+228
to
+231
| const searchInput = document.activeElement; | ||
| if (searchInput instanceof HTMLInputElement || searchInput instanceof HTMLTextAreaElement) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
searchInput should be renamed to activeElement, because it can be not only searchInput
Member
There was a problem hiding this comment.
We not should use activeElement from document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.