multi: Remove unused params from funcs.#3610
Merged
davecgh merged 3 commits intodecred:masterfrom Feb 5, 2026
Merged
Conversation
jholdstock
commented
Feb 5, 2026
| // transaction will be discarded. | ||
| mp.removeStagedTransaction(tx) | ||
| utxoView, err := mp.fetchInputUtxos(txDesc.Tx, isTreasuryEnabled) | ||
| _, err := mp.fetchInputUtxos(txDesc.Tx, isTreasuryEnabled) |
Member
Author
There was a problem hiding this comment.
Perhaps this function call can also be removed?
Member
There was a problem hiding this comment.
It would take reasoning through it to be 100% sure since it's been a while since I've been in this code, but I'm pretty sure the error is still needed because it is possible that the inputs are no longer valid. For example, unstaging happens when a new block shows up and that block might have invalidated the regular tx tree from which one of the staged transactions might be spending and therefore would no longer be valid to spend. There are other cases.
davecgh
changed the title
davecgh
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.