Some fixes and new features for complex mkfiles#7
Open
DiablosOffens wants to merge 2 commits intodcjones:masterfrom
Open
Some fixes and new features for complex mkfiles#7DiablosOffens wants to merge 2 commits intodcjones:masterfrom
DiablosOffens wants to merge 2 commits intodcjones:masterfrom
Conversation
Fix an issue with expansion of escaped newlines. Use the currently set mkfile vars as environment vars for the shell command invoked by "expandBackQuoted".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expandDoubleQuotedthat is encountered if the position of an escape char found in the current substring is less than the position of any other escape char before the current position. Thejvariable was used as the absolute start for the substring and then replaced with the first relative position of the search char in this substring, so in every turnjactually is the relative position but it was used as the absolute start for the new substring. As already mentioned, this leads to an endless loop.I don't know the spec to answer such questions.
mkfilevariables to the environment variables of the new process. The environment variables of the current process are not touched in any way.-lto configure the limit of the recursive rule application. Obviously, the constant 1 was not enough.To test all theses things I tried to build the sml-toolkit. The version 0.5a can be downloaded here.