Support for compose files with different names (as per spec)#33
Open
Joly0 wants to merge 3 commits intodcflachs:mainfrom
Open
Support for compose files with different names (as per spec)#33Joly0 wants to merge 3 commits intodcflachs:mainfrom
Joly0 wants to merge 3 commits intodcflachs:mainfrom
Conversation
Implemented feature to support different file names (per spec https://github.com/compose-spec/compose-spec/blob/main/spec.md#compose-file) for the compose files
Saving files with other names for compose file as per spec now works
Author
|
Ok, everything works now. Some small bugs slipped through, but i fixed them. @dcflachs you can review now. Hopefully these changes work for you aswell so we can merge them :) |
Author
|
@dcflachs Can you please take a look at this? Its a really annoying bug. |
|
I'd also really like to see this change merged |
Author
|
@dcflachs Hey, can you please take a look at this PR and merge it or otherwise tell me whats currently holding it back? Would really like to get this merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, i have been using your compose plugin for quite a while. I noticed, that the file name for the compose file is hardcoded to be "docker-compose.yml".
I tried to add a compose stack for "Perplexica" which uses "docker-compose.yaml", which resulted in the problem, that the stack in the webui kept creating the docker-compose.yml file instead of using docker-compose.yaml
This annoyed me. I also found the comment here #7 (comment) talking about the namings for the files as per spec.
So i decied to tackle this and implemented code to support the four different file names.
I also created test projects on my unraid server locally and tested if this is working:
This shows the five test projects i created. The first four are the different compose file namings as per spec created manually, the fifth is when creating a stack through the gui instead of using an on-disk stack
This is the perplexica stack. Previously this was empty as the compose plugin always created an empty file "docker-compose.yml" and didnt use the "docker-compose.yaml" file.
Perplexica runs now without problems