did I GAT this right?

[jessekrubin]

• move to gats? I am not totally sure I if I GAT/got it right?
• had to google aboot gats a bit more...

@davidhewitt is this what you intended to change based on the TODOs?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.16%. Comparing base (435870c) to head (77dddae).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   84.10%   84.16%   +0.05%     
==========================================
  Files           3        3              
  Lines        1139     1143       +4     
  Branches     1139     1143       +4     
==========================================
+ Hits          958      962       +4     
  Misses        120      120              
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[davidhewitt]

Thanks, this looks good to me!

I will probably wait to merge this until PyO3 upstream bumps MSRV to 1.65 or higher, after which point we'll be good to make use of this here.

[jessekrubin]

@davidhewitt Thanks for taking a look.

Maybe a dumb question, but what is the advantage of gats over not gats?

[davidhewitt]

In some cases they enable patterns that aren't previously possible.

Here, they're just a nice simplification because it removes the lifetime from the trait ident and usage sites to be internal to the implementations.

[jessekrubin]

@davidhewitt thanks so much!

rust is a wild language; I have this sense that rust is very mind-bending to people coming from cpp/java/python/.

[jessekrubin]

@davidhewitt does this pr (PyO3/pyo3#5171) mean we are good to go here?

[davidhewitt]

I will wait until that's merged and released as PyO3 0.26, but yes, soon :)

[davidhewitt]

Great, we're now good to merge here. Thanks again!