Build OpenCV in a build container #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the package installation in the internal_base image. This will enable building OpenCV in a build container, which in the long run will enable us to make the image smaller.
Build OpenCV in a separate build container and copy the built files into the final container. This means we can just build and install without having to worry about cleaning up the build files. This also creates a separate layer for OpenCV, so that will hit the Docker cache more frequently. Also switch to using Ninja while changing things. Ninja is similar to make, but is slightly faster and will use all cores automatically.
This will prevent the container to build if someone manages to replace the OpenCV source archive. As a side effect, this will also cache the archive in the Docker cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the build of OpenCV in a build container. It doesn't look very clear from the GitHub diffview, but there are basically 3 separate changes in this PR:
ADDinstruction for downloading the OpenCV source archive. This makes it easy to perform checksum validation to protect against supply-chain attacks, and as a side benefit it also makes the source archive reside in the Docker cache which speeds up local builds.Besides the security and build time improvements, this is a step on the way towards being able to reduce the size of the image.