Fix 16-bit RGB PNG loaded with 8-bit texture format in WICFileIO#136
Open
CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
Open
Fix 16-bit RGB PNG loaded with 8-bit texture format in WICFileIO#136CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
Conversation
In the bit_depth==16 / PNG_COLOR_TYPE_RGB branch, the texture was allocated with DF_R8G8B8A8_UNORM instead of DF_R16G16B16A16_UNORM, causing a buffer overrun when writing uint16_t data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WICFileIO::Load, thebit_depth==16/PNG_COLOR_TYPE_RGBbranch allocated the texture withDF_R8G8B8A8_UNORMinstead ofDF_R16G16B16A16_UNORM, causing a buffer overrun when writinguint16_tdata.Test plan
DF_R8G8B8A8_UNORM; the 16-bit RGBA/GRAY/GA branches all use 16-bit formats; only the 16-bit RGB branch was wrong.🤖 Generated with Claude Code