Fix wrong preprocessor macro in orthographic projection#127
Open
CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
Open
Fix wrong preprocessor macro in orthographic projection#127CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
Conversation
The orthographic section checked GTE_USE_MAT_VEC while every other usage in the codebase checks GTE_USE_VEC_MAT. In the default build (neither macro defined), this caused the orthographic projection to use VEC_MAT convention while perspective used MAT_VEC. Fixed by changing to GTE_USE_VEC_MAT and swapping the branch bodies. Also fixed missing 2.0f factor in VEC_MAT depth [-1,1] branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The orthographic section of
SetProjectionMatrixchecksGTE_USE_MAT_VECwhile every other#if definedin the codebase checksGTE_USE_VEC_MAT. In the default build (neither macro defined), orthographic uses VEC_MAT convention while perspective uses MAT_VEC — producing inconsistent projection matrices. Fixed the macro and swapped branches. Also fixed a missing2.0ffactor in the VEC_MAT depth [-1,1] branch.🤖 Generated with Claude Code