Skip to content

Fix syntax error in RobustDOP (period instead of semicolon)#121

Open
CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
CodeReclaimers:fix/functions-robustdop-semicolon
Open

Fix syntax error in RobustDOP (period instead of semicolon)#121
CodeReclaimers wants to merge 1 commit intodavideberly:masterfrom
CodeReclaimers:fix/functions-robustdop-semicolon

Conversation

@CodeReclaimers
Copy link
Contributor

Lines 113 and 216 of Functions.h end with . instead of ; inside #if defined(GTE_DISCARD_FMA), causing compilation failure when that macro is defined.

Test: compile with -DGTE_DISCARD_FMA and call RobustDOP.

Test (CMakeLists.txt)
cmake_minimum_required(VERSION 3.14)
project(test_issue_8_1 LANGUAGES CXX)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(GTE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/../../GTE")
add_executable(test_issue_8_1 test_issue_8_1.cpp)
target_include_directories(test_issue_8_1 PRIVATE "${GTE_ROOT}")
target_compile_definitions(test_issue_8_1 PRIVATE GTE_DISCARD_FMA)
Test (test_issue_8_1.cpp)
#include <cstdlib>
#include <cmath>
#include <Mathematics/Functions.h>

int main()
{
    float rf = gte::RobustDOP(1.0f, 2.0f, 0.5f, 1.0f);
    double rd = gte::RobustDOP(1.0, 2.0, 0.5, 1.0);
    bool ok = (std::fabs(rf - 1.5f) < 1e-6f) && (std::fabs(rd - 1.5) < 1e-12);
    return ok ? EXIT_SUCCESS : EXIT_FAILURE;
}

Lines 113 and 216 end with '.' instead of ';' inside #if defined(GTE_DISCARD_FMA),
causing a compilation failure when that macro is defined.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant