This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Bug fix and improvement to handling of :relationships in to_json method#22
Open
BinaryPaean wants to merge 4 commits intodatamapper:masterfrom
Open
Bug fix and improvement to handling of :relationships in to_json method#22BinaryPaean wants to merge 4 commits intodatamapper:masterfrom
BinaryPaean wants to merge 4 commits intodatamapper:masterfrom
Conversation
Author
|
Commits are fix,test,fix,test sequence for convenience. First pair just allow for a null opts in the chained call. Second pair allow for symbol or string arguments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently no check for nil option hash with :relationships opt in to_json, so something like:
cow.to_json({:relationships => {:baby_cows => {}}}) is required.
Null check and test added, along with collection of string/symbol arguments to make
cow.to_json(:relationships => :baby_cows) possible, along with cow.to_json(:relationships => [:baby_cows])