This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Fix for Collection#slice incorrect offset adjustments for chained negative offsets#202
Open
UncleGene wants to merge 1 commit intodatamapper:masterfrom
Open
Fix for Collection#slice incorrect offset adjustments for chained negative offsets#202UncleGene wants to merge 1 commit intodatamapper:masterfrom
UncleGene wants to merge 1 commit intodatamapper:masterfrom
Conversation
…r reversed query (for correct slice with negative offset chaining)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing processing of offset does not account for pre-existing query conditions (such as limit and add_reversed?), thus breaking all cases of chained application of #slice where at least one offset is negative.
Tests for such cases added.
This change can be used as a base for chained #last behavior fix (also broken)