-
Notifications
You must be signed in to change notification settings - Fork 134
Switch init-template to use appkit repo template #4345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keugenek
wants to merge
1
commit into
main
Choose a base branch
from
use-appkit-repo-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the CLI's embedded appkit template (which is out of sync with the SDK), use the template from https://github.com/databricks/appkit. This fixes the getRequestContext API mismatch issue where generated apps use an API that doesn't exist in the @databricks/appkit SDK. See: #4339 Depends on: databricks/appkit#60 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
Commit: 6d53fa6
20 interesting tests: 7 KNOWN, 5 SKIP, 4 RECOVERED, 2 BUG, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
init-template appcommand to use template from https://github.com/databricks/appkit instead of the CLI's embedded templategetRequestContextAPI mismatch where generated apps use an API that doesn't exist in@databricks/appkitBackground
The CLI's embedded appkit template at
experimental/aitools/templates/appkit/uses tRPC withgetRequestContext, but this API doesn't exist in any version of@databricks/appkit(0.1.1-0.1.5).The appkit repo's template at
https://github.com/databricks/appkit/tree/main/templateuses the correct plugin pattern (createApp()+server()+analytics()).Dependencies
Test plan
databricks experimental aitools tools init-template app --name test-appgenerates a working appbundle deployFixes: #4339
🤖 Generated with Claude Code