Added support for UC catalogs (only in direct mode) #4342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Jan 21, 2026
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
Do we want auto-dependency injected between catalogs and schemas like we do for volumes-schemas?
Can you take a look at acceptance/bundle/resources/grants, should we have a test here?
|
|
||
| func (m *validateCatalogsOnlyWithDirect) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics { | ||
| // Catalogs are only supported in direct deployment mode | ||
| if !m.engine.IsDirect() && len(b.Config.Resources.Catalogs) > 0 { |
Contributor
There was a problem hiding this comment.
Do we need this check? What happens without it?
We have TerraformToGroupName map, we should have a general handling of the case when you try to work with resource that is not registered there.
Contributor
Author
There was a problem hiding this comment.
Yes, but the error we get is not really user friendly and does not make it clear what;s going on
Error: no converter for resource type catalogs
Contributor
There was a problem hiding this comment.
Can we improve this error message? Then we don't need custom validators for each new direct-only resource.
Contributor
Author
There was a problem hiding this comment.
Make sense to make it generic but I'd rather keep it in a separate mutator which runs at plan step rather than failing way later at terraform.Write which is when plan is already running
Contributor
There was a problem hiding this comment.
Sure, early check makes sense.
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: ce3a055
17 interesting tests: 7 KNOWN, 5 SKIP, 4 RECOVERED, 1 FAIL
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added support for UC catalogs (only in direct mode)
Why
Supporting UC catalogs is a natural conrinuation of DABs support for UC schemas.
Tests
Added acceptance test