pipelines: warn about unknown attributes #4325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
requested review from
jefferycheng1 and
lennartkats-db
as code owners
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 4dd02a2
18 interesting tests: 7 KNOWN, 5 SKIP, 4 RECOVERED, 2 flaky
Top 46 slowest tests (at least 2 minutes):
|
kanterov
force-pushed
the
handle-unknown-attributes
branch
from
7a3a6fc to
a910de6
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
requested changes
Jan 19, 2026
cmd/pipelines/generate.go
Outdated
Comment on lines
278
to
279
| if librariesDyn.Kind() == dyn.KindNil { | ||
| librariesDyn = dyn.V([]dyn.Value{}) |
Contributor
There was a problem hiding this comment.
This code would benefit from a comment and/or a helper function that just gets librariesDyn.
Collaborator
Author
There was a problem hiding this comment.
Makes sense, fixed
| Catalog string `json:"catalog,omitempty"` | ||
| Database string `json:"database,omitempty"` | ||
| Libraries []sdpPipelineLibrary `json:"libraries,omitempty"` | ||
| Storage string `json:"storage,omitempty"` |
Contributor
There was a problem hiding this comment.
Are you using this?
Collaborator
Author
There was a problem hiding this comment.
It's needed to avoid warnings about unknown attributes
Collaborator
Author
|
@lennartkats-db please take a look again |
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Warn about unknown attributes in spark-pipeline.yml
Why
It avoids cases when spark-pipeline.yml is incorrectly formatted and "pipelines generate" command produces incorrect output.
Tests
Acceptance tests