aitools: Fix default_catalog handling in init-template commands #4312
+11
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't set default_catalog in config map when catalog flag is empty. This lets the template schema default handle the fallback to hive_metastore, instead of passing an empty string which bypasses the default. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 841156f
27 interesting tests: 23 KNOWN, 2 flaky, 1 SKIP, 1 FAIL
Top 42 slowest tests (at least 2 minutes):
|
denik
approved these changes
Jan 19, 2026
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
Generated projects that used the default template were getting an empty catalog: field instead of using the workspace default.
q - is there an acceptance test? this is something that would be easy to notice there.
Contributor
Author
Thanks for asking! We have acceptance tests under https://github.com/databricks/cli/blob/main/acceptance/apps/init-template/job/script, but they only test the CLI output. I'd rather not include the full template output there since the template used is 100% the same as the standard default-python/default-empty templates. So the only thing that's not exercised by the existing acceptance tests is the way parameters are passed via Go code here rather than by shell invocations. (And passing a key + empty value in Go was resulting in unexpected behavior.) So altogether, I don't think it's really worth the overhead of adding acceptance test outputs that need to be updated for all future template changes. |
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Only set
default_catalogwhen explicitly provided via--catalogflag.Why
Generated projects that used the
defaulttemplate were getting an emptycatalog:field instead of using the workspace default.