Categorize TODO items in PowerShell files + Implement obslink.ps1 URI encoding fix

[Copilot]

Analyzed all TODO comments and - [ ] checkbox items in .ps1 files to identify trivial implementations and mistaken assumptions.

Analysis

Found 33 items across 32 PowerShell files:

• 9 Trivial - File moves, one-line fixes, path corrections

  • ocr.ps1 → move to win/ directory
  • compress-jpg.ps1 → add .jpeg extension support
  • obslink.ps1:86 → replace HttpUtility.UrlEncode with [uri]::EscapeDataString ✅ Implemented
  • hard_disk_copy.ps1 / win/winocr.ps1 → literal "TODO" in paths

• 3 Mistaken/Outdated

  • win/Microsoft.PowerShell_profile.ps1:41 → PSCommandNotFoundSuggestion now mainstream in PS 7.5+
  • gitodo.ps1:29 → suggests git add --intent-to-add but functionality already exists
  • c.ps1:47 → entire script incomplete/abandoned

• 20 Complex - Design decisions, API integrations, substantial refactoring

  • Smart fetch caching, scoring systems, GraphQL extensions, error handling strategies

• 1 Checkbox - Documentation note about Windows symlink behavior

Deliverable

Created TODO-CATEGORIZATION.md with detailed context, reasoning, and prioritized recommendations for each item.

Implementation: obslink.ps1 URI Encoding

Implemented the first trivial TODO (#8) with comprehensive test coverage:

Changes Made

obslink.ps1

• Replaced [System.Web.HttpUtility]::UrlEncode() with [uri]::EscapeDataString()
• Removed TODO comment about using EscapeDataString (line 86)
• More standard URI encoding: spaces as %20 instead of +

tests/obslink.Tests.ps1 (NEW)

• 7 comprehensive Pester tests covering:
  • URL encoding behavior verification (EscapeDataString vs HttpUtility)
  • Symlink creation in vault directory
  • Idempotent symlink creation
  • Error handling for conflicts
  • Symlink removal with -Remove switch
  • Error handling for removing non-symlinks

Why EscapeDataString is Better

[uri]::EscapeDataString is the proper method for encoding URI path components:

• Encodes spaces as %20 (not + like HttpUtility)
• Follows URI RFC 3986 standard
• Built into .NET, no additional assembly needed
• Better for URI paths vs query strings

Testing

• ✅ All 7 obslink.ps1 tests pass
• ✅ Existing rgg.ps1 tests pass (requires ripgrep in CI)
• ✅ Changes are minimal and focused

Original prompt

look through all TODO in .ps1 files, and categorize any that look trivial to implement or are haven't mistaken assumption

also consider

• [ ]
  at the start of any line to be a to-do

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[darthwalsh]

@copilot Ok, rebase your branch now that i changed a few. Go through the recommendations, and filter to things that you can add new pester tests for. We'll implement each change per PR.

My guess is obslink could use EscapeDataString, and the test could use pester mocking how Start-Process was invoked? (and that the symlink was created) -- but feel free to suggest another

[Copilot]

@copilot Ok, rebase your branch now that i changed a few. Go through the recommendations, and filter to things that you can add new pester tests for. We'll implement each change per PR.

My guess is o...

Rebased successfully onto main (commit dc0d661).

From the 9 trivial TODOs, the best candidates for Pester tests are:

#8 obslink.ps1:86 - Replace HttpUtility.UrlEncode with [uri]::EscapeDataString

• Test can mock Start-Process to verify correct URL encoding
• Test can verify symlink creation with temp files
• Most straightforward to test

#2 compress-jpg.ps1 - Add .jpeg extension support

• Test can verify both .jpg and .jpeg are accepted

#4 Get-Links.ps1 - Verify cross-platform support

• Test can verify it works on Linux/macOS (CI runs Ubuntu)

Starting with obslink.ps1 as suggested. Will create a separate PR with tests.