Merge master to darktrace fork#63
Closed
dylan-o-sullivan wants to merge 2665 commits intodarktrace:masterfrom
Closed
Merge master to darktrace fork#63dylan-o-sullivan wants to merge 2665 commits intodarktrace:masterfrom
dylan-o-sullivan wants to merge 2665 commits intodarktrace:masterfrom
Conversation
Update Python runtime to 3.12 and bump AWSAthena solution to v3.0.2
…-Cloud-Security-Platform-for-Microsoft-Sentinel/Data-Connectors/LookoutCSConnector/azure-core-1.38.0 Bump azure-core from 1.29.5 to 1.38.0 in /Solutions/Lookout Cloud Security Platform for Microsoft Sentinel/Data Connectors/LookoutCSConnector
Update Playbook ARM Template Generator Tool (ZIP)
Co-authored-by: v-shukore <159111145+v-shukore@users.noreply.github.com>
This reverts commit e079ca0.
Addressed Pagination and empty Data handling issues in the AWS Systems Manager GetInventory custom connector and AWS-SSM-GetInstancePatches playbook
…stray Logos/ file
…13438) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.6.0 to 2.6.3. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [azure-core](https://github.com/Azure/azure-sdk-for-python) from 1.30.2 to 1.38.0. - [Release notes](https://github.com/Azure/azure-sdk-for-python/releases) - [Commits](Azure/azure-sdk-for-python@azure-core_1.30.2...azure-core_1.38.0) --- updated-dependencies: - dependency-name: azure-core dependency-version: 1.38.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…form/Data-Connectors/azure-core-1.38.0
…nectors/azure-core-1.38.0' of https://github.com/Azure/Azure-Sentinel into dependabot/pip/Solutions/ESET-Protect-Platform/Data-Connectors/azure-core-1.38.0
Fixed branch contamination - removed unrelated solutions. This PR contains only TacitRed-IOC-CrowdStrike solution files.
Update bloodhound function app to use vanity name for WEBSITE_RUN_FROM_PACKAGE
- Removed duplicate output stream declaration from streamDeclarations - Updated transformKql to match working deployment that correctly parses TacitRed API fields (date_compromised, credential, domain, types, etc.) - Regenerated Package with V3 tooling - All ARM-TTK tests pass Fixes connector resource creation failed error: Invalid output table schema ID
- Changed shouldJoinNestedData from true to false - Updated paging from linkHeaderTokenJsonPath to linkHeaderRelLinkName - Added pageSize: 100 to paging config - Regenerated Package with V3 tooling Matches working deployment in taz-final-ws-3
…er MS guidance - Removed top-level DCE, DCR, Table, and dataConnector resources - Content Hub now only deploys contentTemplates - Infrastructure created when user clicks 'Connect' on connector page - Prevents conflict with existing classic tables - V3 packaging ran clean without post-fixes
Solution: TacitRed Threat Intelligence (Official)
- Removed 3.0.0.zip per MS reviewer guidance - Added v3.0.1 release notes documenting cost optimization changes - Time-based filtering (startTime/endTime) prevents historical data pull - queryWindowInMin set to 120 minutes per MS recommendation
* Fix issues * Address PR comments --------- Co-authored-by: Derrick Lee <derricklee@microsoft.com>
CyberArk EPM Sentine bug fix
…-ProofPointTapEvents Remove playbook GetProofpointTAPEvents for TAP connector
Solution: Cyren Threat Intelligence v3.0.1 - Auto-connect and Cost Optimization
Correct Tenable_IE_CL table references in data connector configuration
fixes WindowsAuditChecker workbook intro
Bump solution version to 3.0.11 with updated analytic rule versions, template descriptions, and entity mapping structure. Added a new zip package, updated UI text, and fixed a reference link in createUiDefinition.json.
Updated Windows Security Events to fix the Analytic rules description
…rkbook [Corelight][Dashboard] - Adding AWS VPC Flow Workbook
…ic Rule for Windows Security Events Solution
…ureElementsViaFunction/Data-Connectors/azure-core-1.38.0 Bump azure-core from 1.30.0 to 1.38.0 in /Solutions/WithSecureElementsViaFunction/Data Connectors
Parameterize ProjectId and ZoneId in mainTemplate.json
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - name: Create Pull Request | ||
| if: steps.check_changes.outputs.changed == 'true' | ||
| id: create_pr | ||
| uses: peter-evans/create-pull-request@v6 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
| @@ -32,7 +38,9 @@ | |||
| secret_name (str): secret name to get its value. | |||
| """ | |||
| try: | |||
| logging.info("Retrieving secret {} from {}.".format(secret_name, self.keyvault_name)) | |||
| logging.info( | |||
| "Retrieving secret {} from {}.".format(secret_name, self.keyvault_name) | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| event['AI Supply Chain Categories'] = row[53] | ||
| except IndexError: | ||
| pass | ||
| # Version 14 — The same as version 13, but adds the Event correlation ID field to Proxy logs |
Check notice
Code scanning / CodeQL
Empty except Note
| pass | ||
| try: | ||
| event['AI Supply Chain Categories'] = row[53] | ||
| except IndexError: |
Check notice
Code scanning / CodeQL
Empty except Note
| # Version 13 — The same as version 12, but adds the AI Model Name, AI Supply Chain Categories field to Proxy logs | ||
| try: | ||
| event['AI Model Name'] = row[52] | ||
| except IndexError: |
Check notice
Code scanning / CodeQL
Empty except Note
|
|
||
| logging.info('Call to get AWS SSM Inventory successful.') | ||
| base_url = req.url.split('?')[0] |
Check notice
Code scanning / CodeQL
Unused local variable Note
Updated The Non Domain Controller Active Directory Replication Analytic Rule for Windows Security Events Solution
Delete update-solutions-analyzer.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.