Open
Conversation
henryptung
force-pushed
the
clear-cache-on-zoom-change
branch
from
dcb9ea4 to
39028cc
Compare
henryptung
force-pushed
the
clear-cache-on-zoom-change
branch
from
39028cc to
a4a638f
Compare
Owner
|
Hrm ok thanks. |
Contributor
Author
|
So, I realized that I hadn't cleaned up my shapefile before loading, so I was getting a LOT of large metadata cruft on the frontend in a lot of tiles. The burden got significantly lighter once I stopped doing that, so I don't think this is nearly as important. Up to you on whether you want to merge, keep around a branch, or close out (it's still listed under pull requests, anyway). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is somewhat more questionable and not necessarily something you want to merge into master, but I noticed that with significant panning and zooming over time, the UtfGrid layer developed a very large cache of all tiles ever fetched. This adds a zoomend handler that, on zoom change, deletes cache entries that don't match the current zoom, to minimize memory usage at runtime.
As a tradeoff, this means that zooming to level A, B, then back to A will cause tiles to reload from backend whereas they previously did not. Up to you on whether you think it's important.