Added overlay for better user experience#2
Open
stavroskasidis wants to merge 1 commit intodanroth27:mainfrom
Open
Added overlay for better user experience#2stavroskasidis wants to merge 1 commit intodanroth27:mainfrom
stavroskasidis wants to merge 1 commit intodanroth27:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented a loading overlay to help improve the user experience (unresponsive UI) while the wasm runtime is being downloaded and initialized. Hopefully this doesn't break SEO because the overlay is added by javascript to the document. I thought you might want to include it in your sample, ergo I created this PR. Feel free to reject.
Cheers :)