Claim to support the GTK_FRAME_EXTENTS (enables full GTK CSD)
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advertise support for the `GTK_FRAME_EXTENTS` property via `NET_SUPPORTED`. The property, however, is ignored if set, but just advertising support enables full GTK client-side decoration, i.e. rounded corners and drop shadows. Additional bits and pieces might be landed in a follow-up commit.
Author
|
@danakj Just as a reminder of this PR being ready for review 🙂. |
Author
|
Closing this PR in favor of Mikachu/openbox#20, given that according to the openbox website, the official repository is now at https://github.com/Mikachu/openbox/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advertise support for the
GTK_FRAME_EXTENTSproperty viaNET_SUPPORTED. The property, however, is ignored if set, but just advertising support enables full GTK client-side decoration, i.e. rounded corners and drop shadows.Additional bits and pieces might be landed in a follow-up commit. I don't know if
openboxis still maintained, @danakj, but let me know whether having that as part of this PR is a must.Before this patch:
After this patch:
Both pictures were taken running Openbox and Compton as the composition manager.