Open
Conversation
cyphar
force-pushed
the
link-argument-order
branch
from
ed0f49e to
e997ec0
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
cyphar
force-pushed
the
link-argument-order
branch
2 times, most recently
from
c6e1c6a to
426a6a8
Compare
Owner
Author
|
Hmmm, it seems like the symbol versions aren't appearing anymore...? |
For the pathrs_inroot_* API, it is a little cleaner to always have the path to resolve be the first argument. However, when writing the e2e tests I realised that diverging from the syscall API is just going to cause confusion. This is also a decent test case for our symbol versioning being used to keep old binaries working (though in practice this is just a straight-up breakage that doesn't need to be patched over). Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
link-argument-order
branch
from
426a6a8 to
2e9b86d
Compare
cyphar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the pathrs_inroot_* API, it is a little cleaner to always have the
path to resolve be the first argument. However, when writing the e2e
tests I realised that diverging from the syscall API is just going to
cause confusion.
This is also a decent test case for our symbol versioning being used to
keep old binaries working (though in practice this is just a straight-up
breakage that doesn't need to be patched over).
Fixes #267
Signed-off-by: Aleksa Sarai cyphar@cyphar.com