Merged
Conversation
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review code base and documentation for 1.0 readiness
Prepare library for 1.0 release
Feb 1, 2026
Member
|
@copilot CI does not pass (lint/format/tests) |
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Contributor
Author
Fixed in 7c10da3. The issues were:
|
There was a problem hiding this comment.
Pull request overview
This PR prepares the @cross/jwt library for its 1.0 release with critical security fixes, documentation improvements, and version updates.
Changes:
- Fixed RSA-PSS algorithm object mutation bug that could cause cryptographic errors
- Enhanced error handling to prevent information leakage through sanitized error messages
- Updated documentation to remove experimental markers and fix example inconsistencies
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/crypto/sign-verify/rsapss.ts | Fixed critical bug where key.algorithm was being mutated directly; now creates new algorithm object |
| src/core/validate.ts | Added JSON.parse error handling and sanitized error messages in validateJWT, unsafeParseJWT, and unsafeParseJOSEHeader |
| README.md | Removed "Experimental" markers from exportPEMKey/importPEMKey and fixed PEM filename inconsistencies in examples |
| deno.jsonc | Updated version from 0.6.0 to 1.0.0 |
| LICENSE | Updated copyright year from 2024 to 2024-2026 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0 Readiness Review - COMPLETE ✅
This PR prepares the @cross/jwt library for 1.0 release with version updates, documentation improvements, and critical security fixes.
Version & Metadata
Documentation Updates
Security Fixes
Code Quality & CI Fixes
Summary of Changes
Files Modified: 5 files
Security Improvements:
CI Status:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.