Add a reusable <Button/> component #274
Open
+214
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for criipto-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nmoskaleva
force-pushed
the
add-button
branch
from
cedd189 to
a40798b
Compare
jlndk
reviewed
Jan 22, 2026
Open
jlndk
reviewed
Jan 29, 2026
Contributor
jlndk
left a comment
jlndk
left a comment
There was a problem hiding this comment.
Looks really good!
Only one last set of comments about inlined svg icons. Otherwise LGTM
src/components/Button/Button.tsx
Outdated
Comment on lines
110
to
117
| <svg | ||
| className={cx('h-5 w-5 animate-spin-steps', className)} | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| viewBox="0 0 512 512" | ||
| fill="currentColor" | ||
| > | ||
| <path d="M304 48a48 48 0 1 0 -96 0 48 48 0 1 0 96 0zm0 416a48 48 0 1 0 -96 0 48 48 0 1 0 96 0zM48 304a48 48 0 1 0 0-96 48 48 0 1 0 0 96zm464-48a48 48 0 1 0 -96 0 48 48 0 1 0 96 0zM142.9 437A48 48 0 1 0 75 369.1 48 48 0 1 0 142.9 437zm0-294.2A48 48 0 1 0 75 75a48 48 0 1 0 67.9 67.9zM369.1 437A48 48 0 1 0 437 369.1 48 48 0 1 0 369.1 437z" /> | ||
| </svg> |
Contributor
There was a problem hiding this comment.
Can this be replaced with a <FontAwesomeIcon/> to prevent us having to maintain hard-coded copies of the SVG icons?
src/components/URLCodeBlock.tsx
Outdated
Comment on lines
24
to
26
| <svg viewBox="0 0 640 640" fill="currentColor" aria-hidden className="w-5"> | ||
| <path d="M512 416L256 416L256 96L434.7 96L512 173.3L512 416zM544 160L448 64L224 64L224 448L544 448L544 160zM128 192L96 192L96 576L416 576L416 496L384 496L384 544L128 544L128 224L176 224L176 192L128 192z" /> | ||
| </svg> |
Contributor
There was a problem hiding this comment.
Also, can this be replaced with a <FontAwesomeIcon/>?
If not I would propose moving the svg to a dedicated icon component with a descriptive name
src/components/WebhookTester.tsx
Outdated
Comment on lines
327
to
331
| iconLeft={ | ||
| <svg viewBox="0 0 640 640" fill="currentColor" aria-hidden className="w-5"> | ||
| <path d="M128 523.4L128 560L160 542.2L527.1 338.3L560 320L527.1 301.7L160 97.8L128 80L128 523.4zM160 505.6L160 134.4L494.1 320L160 505.6z" /> | ||
| </svg> | ||
| } |
Contributor
There was a problem hiding this comment.
To further align the documentation with the design system.
nmoskaleva
force-pushed
the
add-button
branch
from
2fb60bc to
4926396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To further align the documentation with the design system.
QA: Please check the updated buttons:
button: https://deploy-preview-274--criipto-docs.netlify.app/signatures/webhooks/tester/ (available after you input API credentials, or see screenshot).