Remove useless logs #4084
Open
Remove useless logs #4084
+45
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively removes and strips down chatty logs, as described in the PR description. This includes removing huge structs from debug logs, removing logs for unmergeable solutions, and downgrading some log levels. No critical or high-severity issues were found in the changes that would impact correctness, efficiency, maintainability, or security. The changes align with the goal of reducing log noise.
MartinquaXD
commented
Jan 23, 2026
| }) | ||
| } | ||
|
|
||
| #[instrument(skip_all, fields(auction_id = auction.id, auction_block = auction.block, auction_orders = auction.orders.len()))] |
Contributor
Author
There was a problem hiding this comment.
This change might need some more consideration. IIUC without auction_id in the tempo instrumentation all logs will belong to the same trace.
So perhaps a better option would be to simply adjust the tracing formatter to not print those? cc @fafk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our services are extremely chatty which is annoying for debugging and overwhelms our logging infra. This PR removes or strips down logs that should not be needed.
Changes
debugtotrace(the ones I think I never used for any debugging but on the surface level seemed like they might be useful eventually)/notifyrequests