Open
Conversation
snej
force-pushed
the
feature/weak-refs
branch
from
f5102a3 to
a81baee
Compare
snej
force-pushed
the
feature/weak-refs
branch
from
a81baee to
4320308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
WeakRetained<>/WeakRef<>.See the proposal document in the wiki.
Lockless algorithms are tricky, so I've detailed exactly how this works.
Also implemented
RetainedBySubclassandWeakRetainedBySubclass, which are a bit tricky to explain; see their doc-comments. The latter is basically a clean replacement for LiteCore'sWeakHolder.