Fix comparing nullslice and empty slice#170
Closed
blaugold wants to merge 1 commit intocouchbase:masterfrom
Closed
Fix comparing nullslice and empty slice#170blaugold wants to merge 1 commit intocouchbase:masterfrom
nullslice and empty slice#170blaugold wants to merge 1 commit intocouchbase:masterfrom
Conversation
Contributor
|
I honestly don't recall if this was intentional or not. I worry that changing this behavior could cause regressions in LiteCore or Couchbase Lite. |
Contributor
|
I copied the test case in here, "API Mutable copy of Dict with empty string shared key", into the current master version of Fleece and ran it; it passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLSlice_EqualandFLSlice_Comparehandled thenullsliceand an empty slice as beeing equal.This can cause incorrect behaviour in edge cases where the distinction matters. The added tests contains such a case and did fail before this change.
NB: This was discovered through fuzzing (#166).