Draft: Update node to latest LTS release for build purposes.#239
Open
yagni wants to merge 5 commits intocornerstonejs:masterfrom
Open
Draft: Update node to latest LTS release for build purposes.#239yagni wants to merge 5 commits intocornerstonejs:masterfrom
yagni wants to merge 5 commits intocornerstonejs:masterfrom
Conversation
yagni
changed the title
…dule import syntax.
…ad of istanbul; it seems to be the current recommended coverage package. In order to run in Node, I had to add "type": "module" to the package.json. This had some knock-on effects, like I had to make import statements in the tests ECMAScript-compliant by adding file extensions. I then also had to rename config files that use CommonJS-style require() instead of import to the .cjs extension.
…ng on Webkit. Karma is deprecated and hasn't been updated to work with newer Node.js. The Karma and Angular teams recommend using Web Test Runner now for browser testing.
yagni
force-pushed
the
circleci-node-lts
branch
from
462ddbd to
de2ad6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 16 security support will end 11 Sep 2023 so we need to move off that soon