Skip to content

Cleanup old libs#2

Open
DelofJ wants to merge 2 commits intocoop-deluxe:masterfrom
DelofJ:master
Open

Cleanup old libs#2
DelofJ wants to merge 2 commits intocoop-deluxe:masterfrom
DelofJ:master

Conversation

@DelofJ
Copy link

@DelofJ DelofJ commented Nov 25, 2025

I saw old libs that became unused with the latest commit
Is this intended ?

@DelofJ
Copy link
Author

DelofJ commented Nov 26, 2025

Btw, taking this occasion, I saw that the flag -Wno-error=deprecated-declarations was removed
This causes the build to fail on my machine

server/sha2.cpp:413:9: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
  413 |         sprintf(buf+i*2, "%02x", digest[i]);
      |         ^

And by seeing this comment from previous commits, it seems like you where aware of this issue

# macOS defines sprintf as unsafe, and refuses to compile further, so add this flag to ignore it

So why removing it, is this no longer a thing on more recent macOS versions ?
If that the case, then it's still an issue for us that are on older macOS versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant