Skip to content

Refactor CI/CD and modernize project configuration#106

Open
f3l1x wants to merge 4 commits intomasterfrom
claude/contributte-oss-alignment-1Ops5
Open

Refactor CI/CD and modernize project configuration#106
f3l1x wants to merge 4 commits intomasterfrom
claude/contributte-oss-alignment-1Ops5

Conversation

@f3l1x
Copy link
Member

@f3l1x f3l1x commented Feb 8, 2026

No description provided.

@f3l1x f3l1x requested a review from dakorpar February 10, 2026 12:33
"nette/application": "^3.0"
"php": ">=8.2",
"nette/application": "^3.0.0",
"nette/forms": "^3.2.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will definitely crash.
This library relies heavily on internal implementation details of Nette Forms, making it impossible to avoid being tightly coupled to a specific version of nette/forms.
This has happened in the past, and it will happen again in the future if we allow this.
We need to add a comment here to ensure no one does this again. This has already been discussed in this repository, and this limitation is in place for a reason.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants