feat: Enhance environment connection error handling#512
feat: Enhance environment connection error handling#512Mr-Sunglasses wants to merge 8 commits intocontainers:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mr-Sunglasses The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2fe3b88 to
a8c4fec
Compare
|
Hey @inknos , I've fixed all the suggested changes on PR: #472 in this PR because that was messed up and thanks @D3vil0p3r for your suggestion, I really helped me in resolving this issue. |
dbb5dac to
e56d71a
Compare
|
Thanks, I'll look into it. Since the first time you committed, many things have changed in the codebase and we reformatted and dropped quite a lot of old code. I'll help you with this to fix the remaining issues. it should be a matter of passing the lint and few other things :) |
Sure thanks @inknos , looking forward to your review and also happy to resolve more bugs 😄 |
|
hey. @Mr-Sunglasses I was working on #510 to fix the tests flake that hit the packit jobs, and now they should be good (it was about the infinite running tests). I also published 5.4.0 within the same PR and that should fix all the red lights 🤞🏻 . you might want to pull main, rebase and push your commits again :) |
Sure @inknos thanks a lot, it'll do that right away :-) Let's hope for the best that all tests pass 🧿🤞🏻 |
e56d71a to
93dd525
Compare
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
b4327bb to
b133b37
Compare
fix: #455
Add
PodmanConnectionErrorto improve debugging of connection failures wheninitializing client from environment variables. The new error provides:
Previously, raw exceptions from connection attempts could be confusing to
diagnose, especially when involving environment variables. This change makes it
clearer what went wrong during client initialization.