fileutils_test: check symlink directory location before test #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
reviewed
Jan 22, 2026
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks.
I expect that works, but really tests should not be hard-coding specific paths in /tmp (and exposing the invoking user to attacks by other users on the machine) in the first place. Can you convert the test to be based on t.TempDir(), please? That might work around the macOS /tmp situation as a side effect.
On some systems, /tmp and /var are symlinks to /private/tmp and /private/var, respectively. This may cause the test to fail, because the created directory is not actually at the path where it was created. Get the canonical path of the created directory and compare that to the output of ReadSymlinkedDirectory. While we're here, avoid hardcoding specific test paths and prefer using t.TempDir() instead. This also simplifies the cleanup logic. Signed-off-by: Caleb Xu <caxu@redhat.com>
caxu-rh
force-pushed
the
fileutils-symlink-test
branch
from
19562db to
5d306e0
Compare
Contributor
Author
|
Thanks for the feedback, I made adjustments to avoid using hardcoded paths for the test. The path returned by I wonder if this should work now on Windows too, but I don't have the means to test it right now, so I've left the TODO in place. |
Member
|
If @mtrmac is hip with this, so am I. Provisionally: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, /tmp and /var are symlinks to /private/tmp and /private/var, respectively. This may cause the test to fail, because the created directory is not actually at the path where it was created.
Get the canonical path of the created directory and compare that to the output of ReadSymlinkedDirectory.
While we're here, avoid hardcoding specific test paths and prefer using t.TempDir() instead. This also simplifies the cleanup logic.