Implement support for PodSandboxStatus RPC #267
+1,993
−1,263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great thing to add, thanks @MikeZappa87 ! |
MikeZappa87
force-pushed
the
mzappa/status
branch
2 times, most recently
from
5cae6e9 to
b4bf04c
Compare
klihub
reviewed
Jan 30, 2026
Member
klihub
left a comment
klihub
left a comment
There was a problem hiding this comment.
I have a few questions about the chosen semantics. But it might be that I just lack the necessary context here...
MikeZappa87
force-pushed
the
mzappa/status
branch
from
1b28406 to
6cc0259
Compare
MikeZappa87
commented
Jan 30, 2026
Signed-off-by: Michael Zappa <michael.zappa@gmail.com>
MikeZappa87
force-pushed
the
mzappa/status
branch
from
3690424 to
f713eb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add PodSandboxStatus support to NRI.
The idea to why we want to bring this RPC in now is that we want to try and begin the process to deprecate the CNI and we need a way to return Pod IP's back to the kubelet. Without this we ether need to come up with a new RPC outside of NRI or experiment directly in the kubelet. Using NRI seems to be the best place right now. This is why the PodSandboxStatusResponse type only returns pod ip addresses, its open to more fields be added.
I put together this branch in containerd that brings this NRI branch in and disables the CNI as a test bed.
containerd/containerd@main...MikeZappa87:containerd:mzappa/knext