Update mode to support both react query and orm generation for codegen. Added header support in cli. #615
Conversation
graphql/server/src/middleware/gql.ts
Outdated
| connection: true, | ||
| }, | ||
| schemasByApiSchemaApiIdAndSchemaId: { | ||
| schemataByApiSchemaApiIdAndSchemaId: { |
There was a problem hiding this comment.
this looks like the OLD naming!
NorOldBurden
force-pushed
the
fix/codegen-server-issue
branch
from
ca0e2cf to
1bbf3ca
Compare
|
I have a few questions:
Was there a specific bug with fetch (SSL issues, proxy problems, Node version compatibility)? |
|
Was Host header override the specific issue you hit? Can you share the error or scenario? I need to know the exact scenario that's not working that you run into here. Plz provide some steps to reproduce |
As I showed back in the meeting |
NorOldBurden
force-pushed
the
fix/codegen-server-issue
branch
from
b35ce1a to
3261c95
Compare
yyyyaaa
left a comment
yyyyaaa
left a comment
There was a problem hiding this comment.
and also what's with the code changes for switching from .forEach into for() loops?
Is that intentional or AI hallucination?
packages/cli/src/commands/codegen.ts
Outdated
| : getEnvOptions(); | ||
| const schemasArg = (argv.schemas as string) || ''; | ||
|
|
||
| // Parse repeatable --header args into a headers object |
There was a problem hiding this comment.
this whole thing could be a separate function, hard to read like this imo
There was a problem hiding this comment.
It was just a lint issue, it keeps showing red line. So you prefer the old style?
There was a problem hiding this comment.
I moved headers logics into a function, also reformat the foreach to keep the original syntax while cast variable into any to avoid lint issue.
NorOldBurden
changed the title
NorOldBurden
force-pushed
the
fix/codegen-server-issue
branch
from
aa4536b to
9420656
Compare
No description provided.