-
Notifications
You must be signed in to change notification settings - Fork 42
Upgrade regal to v0.37.0 and fix resulting linting violations #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Acepresso
wants to merge
10
commits into
conforma:main
Choose a base branch
from
Acepresso:regal-upgrade-EC-1617
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+149
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
1d3aae6 to
e627240
Compare
The Regal project has moved from github.com/styrainc/regal to github.com/open-policy-agent/regal. Update go.mod and import statements accordingly. This upgrade introduces new linting rules that will need to be addressed in a follow-up commit. Also upgraded: conftest to v0.66.0 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Ref: https://issues.redhat.com/browse/EC-1617
…erence These import-related lint violations came with a recent Regal package upgrade to v0.3x. Since they require changing hunderds of references in the code, they are ignored and will be addressed in a dedicated PR. - unresolved-reference - pointless-import
e627240 to
3a366a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade regal to v0.37.0 and fix resulting linting violations.
These import-related lint violations require significant changes (many references in many files), so they are ignored and I'll create another story to handle them.
also upgraded in this PR: conftest to v0.66.0