-
Notifications
You must be signed in to change notification settings - Fork 20
[APIE-679] Multi-Env support in AWS - CLI #3223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds multi-environment support for AWS ingress private link functionality in the CLI, extending the existing egress private link capabilities. The changes enable users to create, manage, and interact with AWS ingress private link gateways and endpoints.
Key Changes:
- Added support for AWS ingress private link gateway type alongside existing egress private link
- Implemented complete CRUD operations for ingress endpoints (create, list, describe, update, delete)
- Updated dependency versions for networking-access-point and networking-gateway SDKs
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/network/command_gateway.go |
Added AWS ingress private link gateway type constants and mapping |
internal/network/command_gateway_create.go |
Added ingress-privatelink gateway creation support with AWS-only validation |
internal/network/command_gateway_list.go |
Extended list command to display region and principal ARN for ingress gateways |
internal/network/command_access_point_private_link.go |
Added ingress-endpoint subcommand to private-link command tree |
internal/network/command_access_point_private_link_ingress_endpoint.go |
Core ingress endpoint functionality including output formatting and autocomplete |
internal/network/command_access_point_private_link_ingress_endpoint_create.go |
Implements ingress endpoint creation with AWS VPC endpoint service configuration |
internal/network/command_access_point_private_link_ingress_endpoint_list.go |
Lists ingress endpoints with filtering by display names |
internal/network/command_access_point_private_link_ingress_endpoint_describe.go |
Describes individual ingress endpoint details |
internal/network/command_access_point_private_link_ingress_endpoint_update.go |
Updates ingress endpoint display name |
internal/network/command_access_point_private_link_ingress_endpoint_delete.go |
Deletes one or more ingress endpoints with confirmation |
go.mod |
Updated SDK dependencies to internal versions with ingress support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Release Notes
Breaking Changes
New Features
--type ingress-privatelinkflag toconfluent network gateway createto support a new type of Ingress Private Link for AWS, and add--display-name,--region,--id, and--phaseflags toconfluent network gateway listcommand to support filtering gatewaysconfluent network access-point private-link ingress-endpoint [ create | update | describe | list | delete ]commands to support a new type of Ingress Private Link for AWSBug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
This PR extends the existing Gateway and Access Point functionality to support a new Gateway and Access Point type (Ingress Private Link) for AWS.
More context:
Today, customers face challenges when connecting a single VPC to multiple Confluent Cloud environments (e.g., production, development, QA) within the same AWS region.
This change is part of the broader initiative to migrate the existing PLATT/PLATTC APIs to the new Gateway and Access Point model. Within the current scope, the original functionality remains unchanged.
By enabling an AccessPoint-based endpoint backed by Ingress Private Link, this feature resolves the multi-environment PLATT limitation and allows customers to cleanly connect multiple Confluent Cloud environments from a single VPC.
Blast Radius
Should be minimal. This change is additive only so should not impact or block any existing customer workflows.
References
Corresponding JIRA Ticket: Multi-Env support in AWS/Azure/GCP - CLI
Test & Review
Validation Doc APIE-679 Multi-Env support CLI Testing